refactor: Use strong typedef for NGC peer id. - #2643
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
==========================================
- Coverage 73.77% 73.70% -0.08%
==========================================
Files 148 148
Lines 30473 30482 +9
==========================================
- Hits 22482 22466 -16
- Misses 7991 8016 +25 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
bitwise-gc-peer-id
branch
from
February 4, 2024 22:28
43f8947 to
1a78232
Compare
iphydf
marked this pull request as ready for review
February 4, 2024 22:33
iphydf
force-pushed
the
bitwise-gc-peer-id
branch
from
February 4, 2024 22:34
1a78232 to
911cf87
Compare
JFreegman
approved these changes
Feb 5, 2024
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
bitwise-gc-peer-id
branch
from
February 6, 2024 22:19
b95b67c to
c07989b
Compare
Member
Author
|
@nurupo I've refactored this one as well to have a |
iphydf
force-pushed
the
bitwise-gc-peer-id
branch
2 times, most recently
from
February 9, 2024 02:37
b0db592 to
682e4ff
Compare
iphydf
commented
Feb 9, 2024
iphydf
left a comment
iphydf
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed 1 of 8 files at r1, 2 of 4 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status:
This makes me wonder (again) whether we should somehow share types between the public API and the internal ones. All these casts (including the enum casts we already do) are not very nice.
iphydf
force-pushed
the
bitwise-gc-peer-id
branch
from
February 9, 2024 22:58
682e4ff to
ca4606d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes me wonder (again) whether we should somehow share types between the public API and the internal ones. All these casts (including the enum casts we already do) are not very nice.
This change is