refactor: Make ToxAV independent of toxcore internals.#2651
refactor: Make ToxAV independent of toxcore internals.#2651iphydf merged 1 commit intoTokTok:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
==========================================
- Coverage 73.08% 73.04% -0.04%
==========================================
Files 149 149
Lines 30531 30478 -53
==========================================
- Hits 22313 22263 -50
+ Misses 8218 8215 -3 ☔ View full report in Codecov by Sentry. |
e59814d to
8a4092b
Compare
|
This is ready for review. |
8a4092b to
55a8294
Compare
e0896da to
756ee54
Compare
eb8a05a to
5b737a8
Compare
5b737a8 to
59d3feb
Compare
664ee5f to
560cd96
Compare
dac5f88 to
d4978a3
Compare
d4978a3 to
3297b62
Compare
|
@Green-Sky "m_lossy_rtp_packet_cb" is actually a leftover that should be deleted. same as "RTP_Packet_Handler" |
f02b881 to
be10b4c
Compare
True, fixed. |
|
@Green-Sky mergeable is failing because of the commit messages missing "refactor" or similar |
Yes, that is going to go away when I squash this pr. |
be10b4c to
e99b171
Compare
e99b171 to
c4cdea6
Compare
c4cdea6 to
717aefe
Compare
717aefe to
a57c2c8
Compare
iphydf
left a comment
There was a problem hiding this comment.
Reviewed 12 of 26 files at r1, 3 of 4 files at r2, 3 of 5 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @goldroom and @Green-Sky)
Green-Sky
left a comment
There was a problem hiding this comment.
Reviewed 12 of 26 files at r1, 3 of 4 files at r2, 3 of 5 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @goldroom)
closes #1431
This change is