Skip to content

refactor: Make ToxAV independent of toxcore internals.#2651

Merged
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:toxav-public-api
Nov 8, 2024
Merged

refactor: Make ToxAV independent of toxcore internals.#2651
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:toxav-public-api

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Feb 7, 2024

closes #1431

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Feb 7, 2024
@iphydf iphydf marked this pull request as ready for review February 7, 2024 22:48
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 58.86364% with 181 lines in your changes missing coverage. Please review.

Project coverage is 73.04%. Comparing base (102a1fa) to head (5f97890).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
toxav/msi.c 55.40% 66 Missing ⚠️
toxav/rtp.c 57.25% 53 Missing ⚠️
toxav/toxav.c 71.90% 34 Missing ⚠️
toxav/bwcontroller.c 15.15% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2651      +/-   ##
==========================================
- Coverage   73.08%   73.04%   -0.04%     
==========================================
  Files         149      149              
  Lines       30531    30478      -53     
==========================================
- Hits        22313    22263      -50     
+ Misses       8218     8215       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the toxav-public-api branch 2 times, most recently from e59814d to 8a4092b Compare February 9, 2024 02:34
@iphydf
Copy link
Member Author

iphydf commented Feb 11, 2024

This is ready for review.

@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Feb 11, 2024
@iphydf iphydf marked this pull request as draft March 7, 2024 16:20
@iphydf iphydf force-pushed the toxav-public-api branch from 55a8294 to e0896da Compare March 7, 2024 16:20
@iphydf iphydf force-pushed the toxav-public-api branch from e0896da to 756ee54 Compare March 15, 2024 11:51
@iphydf iphydf force-pushed the toxav-public-api branch 2 times, most recently from eb8a05a to 5b737a8 Compare March 28, 2024 15:22
@Green-Sky Green-Sky marked this pull request as ready for review April 27, 2024 13:03
@iphydf iphydf force-pushed the toxav-public-api branch from 0f687cf to 62159e2 Compare May 1, 2024 13:31
@Green-Sky Green-Sky force-pushed the toxav-public-api branch 2 times, most recently from 664ee5f to 560cd96 Compare September 18, 2024 07:02
Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toxav_old.c uses the Messenger logger, instead the ToxAV logger.

edit: I see that they are still more tightly coupled to messenger and conferences. Maybe we just remove them for v0.3 ?

@zoff99
Copy link

zoff99 commented Nov 4, 2024

@Green-Sky "m_lossy_rtp_packet_cb" is actually a leftover that should be deleted. same as "RTP_Packet_Handler"

@Green-Sky
Copy link
Member

@Green-Sky "m_lossy_rtp_packet_cb" is actually a leftover that should be deleted. same as "RTP_Packet_Handler"

True, fixed.

@zoff99
Copy link

zoff99 commented Nov 5, 2024

@Green-Sky mergeable is failing because of the commit messages missing "refactor" or similar

@Green-Sky
Copy link
Member

@Green-Sky mergeable is failing because of the commit messages missing "refactor" or similar

Yes, that is going to go away when I squash this pr.

@Green-Sky Green-Sky added toxav Audio/video refactor Refactoring production code, eg. renaming a variable, not affecting semantics labels Nov 7, 2024
Copy link
Member Author

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 26 files at r1, 3 of 4 files at r2, 3 of 5 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @goldroom and @Green-Sky)

Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 26 files at r1, 3 of 4 files at r2, 3 of 5 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @goldroom)

@iphydf iphydf changed the title refactor: Make ToxAV independent of toxcore internals. refactor: Make ToxAV independent of toxcore internals Nov 8, 2024
@iphydf iphydf changed the title refactor: Make ToxAV independent of toxcore internals refactor: Make ToxAV independent of toxcore internals. Nov 8, 2024
@iphydf iphydf merged commit a57c2c8 into TokTok:master Nov 8, 2024
@iphydf iphydf deleted the toxav-public-api branch November 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring production code, eg. renaming a variable, not affecting semantics toxav Audio/video

Development

Successfully merging this pull request may close these issues.

4 participants