fix: Fix some false positive from PVS Studio.#2657
Merged
Conversation
nurupo
approved these changes
Feb 9, 2024
Member
nurupo
left a comment
nurupo
left a comment
There was a problem hiding this comment.
Yep, dereferencing a pointer first and then checking if it's null a line below is indeed eyebrow rising, good on it to complain.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
==========================================
+ Coverage 73.71% 73.75% +0.03%
==========================================
Files 148 148
Lines 30481 30481
==========================================
+ Hits 22469 22480 +11
+ Misses 8012 8001 -11 ☔ View full report in Codecov by Sentry. |
It correctly warns about potentially dereferencing NULL chat in a log statement. However, chat can semantically never be NULL in that call, and it's just a defensive check. Still good to fix for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It correctly warns about potentially dereferencing NULL chat in a log statement. However, chat can semantically never be NULL in that call, and it's just a defensive check. Still good to fix for clarity.
This change is