cleanup: Simplify custom packet length check in NGC. - #2659
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
==========================================
+ Coverage 73.72% 73.77% +0.05%
==========================================
Files 148 148
Lines 30479 30473 -6
==========================================
+ Hits 22470 22482 +12
+ Misses 8009 7991 -18 ☔ View full report in Codecov by Sentry. |
iphydf
marked this pull request as ready for review
February 9, 2024 00:31
JFreegman
approved these changes
Feb 9, 2024
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
nurupo
approved these changes
Feb 9, 2024
nurupo
left a comment
nurupo
left a comment
Member
There was a problem hiding this comment.
Co-authored-by: nurupo
Co-authored-by: zoff99
:P
Co-authored-by: Maxim Biro <nurupo.contributions@gmail.com> Co-authored-by: zoff99 <zoff99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is