fix: Add missing memunlock of local variable when it goes out of scope.#2660
Merged
iphydf merged 1 commit intoTokTok:masterfrom Feb 9, 2024
Merged
fix: Add missing memunlock of local variable when it goes out of scope.#2660iphydf merged 1 commit intoTokTok:masterfrom
iphydf merged 1 commit intoTokTok:masterfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2660 +/- ##
==========================================
- Coverage 73.70% 73.69% -0.02%
==========================================
Files 148 148
Lines 30478 30479 +1
==========================================
- Hits 22464 22461 -3
- Misses 8014 8018 +4 ☔ View full report in Codecov by Sentry. |
JFreegman
approved these changes
Feb 9, 2024
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
nurupo
approved these changes
Feb 9, 2024
Issue found by PVS Studio. It also found another one, but that's a false positive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue found by PVS Studio. It also found another one, but that's a false positive.
This change is