chore: Disable NGC saving by default, enable through Tox_Options.#2678
Merged
Conversation
iphydf
marked this pull request as ready for review
February 11, 2024 15:21
iphydf
force-pushed
the
experimental-ngc-save
branch
from
February 11, 2024 15:30
35e41e8 to
8e72692
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2678 +/- ##
==========================================
- Coverage 73.75% 73.11% -0.64%
==========================================
Files 148 148
Lines 30482 30487 +5
==========================================
- Hits 22482 22292 -190
- Misses 8000 8195 +195 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
experimental-ngc-save
branch
from
February 11, 2024 16:10
8e72692 to
7d1bf7c
Compare
This way, clients can decide whether they want to depend on unstable functionality while we change the NGC save format. We can release with experimental functionality disabled by default.
iphydf
force-pushed
the
experimental-ngc-save
branch
from
February 11, 2024 16:22
7d1bf7c to
8201019
Compare
JFreegman
approved these changes
Feb 11, 2024
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, clients can decide whether they want to depend on unstable functionality while we change the NGC save format. We can release with experimental functionality disabled by default.
This change is