cleanup: Don't use memcpy to cast arbitrary structs to uint8_t[].#2684
Merged
Conversation
We can memcpy integral types and array types. There's no need to directly memcpy into or from struct types.
iphydf
force-pushed
the
no-struct-bytes-cast
branch
from
c18eb8e to
623e3ee
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
+ Coverage 72.94% 73.11% +0.17%
==========================================
Files 148 148
Lines 30486 30486
==========================================
+ Hits 22238 22291 +53
+ Misses 8248 8195 -53 ☔ View full report in Codecov by Sentry. |
Member
|
I thought we ran autotests on ipv6 too? |
Member
Author
I'm not sure we run those on CI. Why are you asking? |
Member
|
Maybe this warning has something to do with it
|
nurupo
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can memcpy integral types and array types. There's no need to directly memcpy into or from struct types.
This change is