Skip to content

fix: Don't serve files from websockify.#2695

Merged
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:websockify-no-files
Feb 18, 2024
Merged

fix: Don't serve files from websockify.#2695
toktok-releaser merged 1 commit into
TokTok:masterfrom
iphydf:websockify-no-files

Conversation

@iphydf

@iphydf iphydf commented Feb 17, 2024

Copy link
Copy Markdown
Member

Fixes security warning on websockify. It's not important, since this program isn't used, but it's better to not have vulnerable code in a security focussed project.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Feb 17, 2024
@iphydf iphydf marked this pull request as ready for review February 17, 2024 20:49
Fixes security warning on websockify. It's not important, since this
program isn't used, but it's better to not have vulnerable code in a
security focussed project.
@iphydf iphydf force-pushed the websockify-no-files branch from c18c1f9 to 86f5e55 Compare February 17, 2024 20:52
@codecov

codecov Bot commented Feb 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (710eb67) 73.10% compared to head (86f5e55) 73.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
+ Coverage   73.10%   73.14%   +0.04%     
==========================================
  Files         149      149              
  Lines       30517    30517              
==========================================
+ Hits        22309    22322      +13     
+ Misses       8208     8195      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toktok-releaser toktok-releaser merged commit 86f5e55 into TokTok:master Feb 18, 2024
@iphydf iphydf deleted the websockify-no-files branch February 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants