Skip to content

refactor: Remove "mod" and "founder" from group API naming scheme - #2709

Merged
iphydf merged 1 commit into
TokTok:masterfrom
JFreegman:group_api_name_changes
Feb 23, 2024
Merged

iphydf merged 1 commit into
TokTok:masterfrom
JFreegman:group_api_name_changes

Conversation

@JFreegman

@JFreegman JFreegman commented Feb 23, 2024 •

Copy link
Copy Markdown
Member

This change is Reviewable

@JFreegman JFreegman added the chore Updating grunt tasks etc; no production code change label Feb 23, 2024
@JFreegman JFreegman added this to the v0.2.19 milestone Feb 23, 2024
@codecov

codecov Bot commented Feb 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 8.96552% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 73.05%. Comparing base (12bc042) to head (77e0887).

Files Patch % Lines
toxcore/tox_api.c 0.00% 99 Missing ⚠️
toxcore/tox.c 28.26% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2709      +/-   ##
==========================================
+ Coverage   72.84%   73.05%   +0.20%     
==========================================
  Files         149      149              
  Lines       30517    30517              
==========================================
+ Hits        22229    22293      +64     
+ Misses       8288     8224      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf changed the title chore: Remove "mod" and "founder" from group API naming scheme refactor: Remove "mod" and "founder" from group API naming scheme Feb 23, 2024
@iphydf
iphydf merged commit 77e0887 into TokTok:master Feb 23, 2024
@JFreegman
JFreegman deleted the group_api_name_changes branch February 23, 2024 14:45
@JFreegman JFreegman added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Updating grunt tasks etc; no production code change refactor Refactoring production code, eg. renaming a variable, not affecting semantics

Development

Successfully merging this pull request may close these issues.

2 participants