Skip to content

refactor: Rename out parameters to out_$something. - #2726

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:no-out
Mar 9, 2024
Merged

refactor: Rename out parameters to out_$something.#2726
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:no-out

Conversation

@iphydf

@iphydf iphydf commented Mar 6, 2024

Copy link
Copy Markdown
Member

In preparation for supporting out as a type qualifier in parameters.


This change is Reviewable

@iphydf iphydf added this to the v0.2.20 milestone Mar 6, 2024
@codecov

codecov Bot commented Mar 6, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.95918% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.14%. Comparing base (0199c0f) to head (3e05824).

Files Patch % Lines
toxcore/group_pack.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
+ Coverage   72.99%   73.14%   +0.14%     
==========================================
  Files         149      149              
  Lines       30516    30516              
==========================================
+ Hits        22276    22321      +45     
+ Misses       8240     8195      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Mar 8, 2024
@iphydf
iphydf marked this pull request as ready for review March 8, 2024 11:14
In preparation for supporting `out` as a type qualifier in parameters.
@iphydf
iphydf merged commit 3e05824 into TokTok:master Mar 9, 2024
@iphydf
iphydf deleted the no-out branch March 9, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants