feat: add message IDs to private group messages#2727
Merged
JFreegman merged 1 commit intoTokTok:masterfrom Mar 7, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2727 +/- ##
==========================================
+ Coverage 73.05% 73.13% +0.07%
==========================================
Files 149 149
Lines 30499 30516 +17
==========================================
+ Hits 22282 22317 +35
+ Misses 8217 8199 -18 ☔ View full report in Codecov by Sentry. |
64a21a1 to
2b0bd4f
Compare
Member
|
you need to adjust the event here: c-toxcore/other/event_tooling/generate_event_c.cpp Lines 744 to 761 in b3c3c49 |
23b5dcc to
0a93263
Compare
Green-Sky
approved these changes
Mar 7, 2024
Member
|
@JFreegman commit message is wrong, needs to be messages, not packets. |
0a93263 to
f64894b
Compare
Green-Sky
approved these changes
Mar 7, 2024
f64894b to
7b1db6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is