chore: Fix Circle CI build failing#2755
Merged
Merged
Conversation
47f3c91 to
99a5bea
Compare
The ubsan build fails due to the missing /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.ubsan_standalone-x86_64.a which is provided by the libclang-rt-18-dev package, which would be installed if we didn't disallow recommends. Installing it manually is not practical, as using libclang-rt-18-dev once clang updates to version 19 would be wrong, and installing libclang-rt-*-dev would attempt to install all of them, either failing or installing all of the clang version available along with them. Thus allowing apt to automatically install recommended packages seems like best solution.
Green-Sky
approved these changes
Apr 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2755 +/- ##
==========================================
- Coverage 73.09% 73.08% -0.02%
==========================================
Files 149 149
Lines 30531 30531
==========================================
- Hits 22317 22313 -4
- Misses 8214 8218 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circle CI's image got updated to use Ubuntu 24.04 (Noble Numbat), which:
libclang_rt.ubsan_standalone-x86_64.ais no longer getting installed-Wswitch-defaultand-Wunsafe-buffer-usage:We actually do not want a default in our switches, we want to explicitly handle every case and get warned when we don't, so
-Wswitch-defaultshould be disables-Wunsafe-buffer-usageseems to be broken, it warns on things that are perfectly ok, like doingfoo[1] = 0;whereuint32_t foo[4];, e.g.warning:
on:
c-toxcore/toxcore/network.c
Line 966 in da43876
where
uint32is:c-toxcore/toxcore/network.h
Line 200 in da43876
This change is