chore(cmake): set options changes as cache and with force#2762
Merged
toktok-releaser merged 1 commit intoTokTok:masterfrom Nov 6, 2024
Merged
chore(cmake): set options changes as cache and with force#2762toktok-releaser merged 1 commit intoTokTok:masterfrom
toktok-releaser merged 1 commit intoTokTok:masterfrom
Conversation
Member
Author
|
Alternatively one can use OR we split toxcore properly into multiple libraries, but that's more of an v0.3 scope change. |
Without this, changes will not propergate to a parent if toxcore is used as a subdirectory.
Green-Sky
force-pushed
the
cmake_option_visibility
branch
from
cca1738 to
e9076f4
Compare
iphydf
approved these changes
Nov 6, 2024
iphydf
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, changes will not propergate to a parent if toxcore is used as a subdirectory.
This change is