fix(toxav): pass video bit rate as kbit#2782
Merged
toktok-releaser merged 1 commit intoTokTok:masterfrom Nov 9, 2024
Merged
Conversation
Member
Author
|
every client assumes kbits (as they should):
tomato currently assumes Mbits, but only because I know about this bug. |
724103b to
fa723e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2782 +/- ##
==========================================
- Coverage 73.04% 72.96% -0.08%
==========================================
Files 149 149
Lines 30478 30566 +88
==========================================
+ Hits 22263 22303 +40
- Misses 8215 8263 +48 ☔ View full report in Codecov by Sentry. |
Previously we unintentionally made it Mbit.
fa723e3 to
55752a2
Compare
iphydf
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we unintentionally made it Mbit.
This change is