Change toxencryptsave API to never overwrite pass keys. - #334
Conversation
|
Formatting could be perhaps improved, but aside from that public API looks fine. Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. toxencryptsave/toxencryptsave.h, line 244 at r1 (raw file):
Formatting? Also functions' args could be formatted. Comments from Reviewable |
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
|
Assigned toxbot to avoid accidentally pushing this since it's green. Also to make it not green so I don't get distracted by green PRs that can't be merged. |
c3e800e to
c54dc7b
Compare
7f0aec5 to
5f33b11
Compare
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. toxencryptsave/toxencryptsave.h, line 244 at r1 (raw file): Previously, zetok wrote…
Formatting needs to be fixed in apidsl. For that, apidsl needs to become smarter and know more about the semantics of a comment. For now, I'd like to leave it like this to keep the .api file nice. Comments from Reviewable |
|
Reviewed 4 of 4 files at r2. Comments from Reviewable |
|
Is this PR ready-to-merge ? |
|
It's an API break, so it's waiting for 0.2, which is a bit more than a month away. Review status: 2 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Comments from Reviewable |
|
Reviewed 4 of 4 files at r3. Comments from Reviewable |
This change is