Skip to content

Change toxencryptsave API to never overwrite pass keys. - #334

Merged
robinlinden merged 1 commit into
TokTok:masterfrom
iphydf:tes-api2
Dec 30, 2017
Merged

Change toxencryptsave API to never overwrite pass keys.#334
robinlinden merged 1 commit into
TokTok:masterfrom
iphydf:tes-api2

Conversation

@iphydf

@iphydf iphydf commented Dec 16, 2016

Copy link
Copy Markdown
Member

This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Dec 16, 2016
@zetok

zetok commented Dec 16, 2016

Copy link
Copy Markdown

Formatting could be perhaps improved, but aside from that public API looks fine. :lgtm_strong:


Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


toxencryptsave/toxencryptsave.h, line 244 at r1 (raw file):

 *
 * The Tox_Pass_Key structure is hidden in the implementation. It can be created
 * using tox_pass_key_derive or tox_pass_key_derive_with_salt and must be deallocated using tox_pass_key_free.

Formatting? Also functions' args could be formatted.


Comments from Reviewable

@robinlinden

Copy link
Copy Markdown

:lgtm_strong:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@iphydf

iphydf commented Dec 22, 2016

Copy link
Copy Markdown
Member Author

Assigned toxbot to avoid accidentally pushing this since it's green. Also to make it not green so I don't get distracted by green PRs that can't be merged.

@iphydf
iphydf force-pushed the tes-api2 branch 2 times, most recently from c3e800e to c54dc7b Compare December 23, 2016 02:37
@iphydf
iphydf force-pushed the tes-api2 branch 2 times, most recently from 7f0aec5 to 5f33b11 Compare January 4, 2017 18:47
@iphydf iphydf added the api break Change breaks API or ABI label Jan 5, 2017
@iphydf

iphydf commented Jan 8, 2017

Copy link
Copy Markdown
Member Author

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.


toxencryptsave/toxencryptsave.h, line 244 at r1 (raw file):

Previously, zetok wrote…

Formatting? Also functions' args could be formatted.

Formatting needs to be fixed in apidsl. For that, apidsl needs to become smarter and know more about the semantics of a comment. For now, I'd like to leave it like this to keep the .api file nice.


Comments from Reviewable

@robinlinden

Copy link
Copy Markdown

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


Comments from Reviewable

@iphydf iphydf modified the milestone: v0.2.0 Jan 10, 2017
@iphydf iphydf modified the milestone: v0.2.0 Jan 12, 2017
@SkyzohKey

Copy link
Copy Markdown

Is this PR ready-to-merge ?

@iphydf

iphydf commented Jan 24, 2017

Copy link
Copy Markdown
Member Author

It's an API break, so it's waiting for 0.2, which is a bit more than a month away.


Review status: 2 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@robinlinden

Copy link
Copy Markdown

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


Comments from Reviewable

@robinlinden
robinlinden merged commit d26f0eb into TokTok:master Dec 30, 2017
@iphydf
iphydf deleted the tes-api2 branch December 30, 2017 00:36
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api break Change breaks API or ABI

Development

Successfully merging this pull request may close these issues.

6 participants