New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pthreads in AppVeyor build #479

Merged
merged 2 commits into from Feb 21, 2017

Conversation

Projects
None yet
3 participants
@nurupo
Member

nurupo commented Feb 20, 2017

The AppVeyor MSVC build is failing because it can't find pthreads library. This PR fixes that.


This change is Reviewable

@nurupo

This comment has been minimized.

Show comment
Hide comment
@nurupo

nurupo Feb 20, 2017

Member

Pthread issue seems to have been fixed, now it fails on something not pthreads related

C:\projects\c-toxcore\toxcore\DHT.c(870): error C2057: expected constant expression [C:\projects\c-toxcore\toxdht_static.vcxproj]
C:\projects\c-toxcore\toxcore\DHT.c(870): error C2466: cannot allocate an array of constant size 0 [C:\projects\c-toxcore\toxdht_static.vcxproj]
C:\projects\c-toxcore\toxcore\DHT.c(870): error C2133: 'cmp_list': unknown size [C:\projects\c-toxcore\toxdht_static.vcxproj]
Member

nurupo commented Feb 20, 2017

Pthread issue seems to have been fixed, now it fails on something not pthreads related

C:\projects\c-toxcore\toxcore\DHT.c(870): error C2057: expected constant expression [C:\projects\c-toxcore\toxdht_static.vcxproj]
C:\projects\c-toxcore\toxcore\DHT.c(870): error C2466: cannot allocate an array of constant size 0 [C:\projects\c-toxcore\toxdht_static.vcxproj]
C:\projects\c-toxcore\toxcore\DHT.c(870): error C2133: 'cmp_list': unknown size [C:\projects\c-toxcore\toxdht_static.vcxproj]
@nurupo

This comment has been minimized.

Show comment
Hide comment
@nurupo

nurupo Feb 20, 2017

Member

I guess this VLA was missed in #452. There is even a comment about that in the PR thread.

Member

nurupo commented Feb 20, 2017

I guess this VLA was missed in #452. There is even a comment about that in the PR thread.

@nurupo

This comment has been minimized.

Show comment
Hide comment
@nurupo

nurupo Feb 20, 2017

Member

Once this, #480 and #481 are merged, AppVeyor should build successfully (I have previous merged those PRs in this PR to just check).

Member

nurupo commented Feb 20, 2017

Once this, #480 and #481 are merged, AppVeyor should build successfully (I have previous merged those PRs in this PR to just check).

@Diadlo

This comment has been minimized.

Show comment
Hide comment
@Diadlo

Diadlo Feb 20, 2017

:lgtm_strong:


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

Diadlo commented Feb 20, 2017

:lgtm_strong:


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nurupo nurupo changed the title from [WIP] Fix pthreads in AppVeyor build to Fix pthreads in AppVeyor build Feb 20, 2017

@iphydf iphydf merged commit 1cc119c into TokTok:master Feb 21, 2017

2 of 6 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci CircleCI is running your tests
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iphydf iphydf added this to the v0.1.7 milestone Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment