-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the bug when receipts for messages sent from the receipt callback never arrived. #500
Conversation
Fascinating. Can you add a test case that fails without this change? |
Are there any testcases of this kind? It requires 2 peers. |
Just create 2 Tox instances. Make sure to use |
Please enable the checkbox "Allow edits from maintainers." on the bottom right. |
As nurupo said, create 2 tox instances and make them iterate() in the same loop. |
@yurivict if you enable the checkbox, we can add the test case for you if you're unable to do so. |
"Allow edits from maintainers." is on. |
I won't have time to add a test case. Once you're available again, please add one. |
Let's merge it with a TODO for a test case. |
6a32c69
to
d418e67
Compare
…ck never arrived.
d418e67
to
a3a22ae
Compare
Reviewed 1 of 1 files at r1, 1 of 1 files at r2. Comments from Reviewable |
#493
This change is