Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug when receipts for messages sent from the receipt callback never arrived. #500

Merged
merged 1 commit into from Dec 17, 2017

Conversation

@yurivict
Copy link
Member

@yurivict yurivict commented Mar 5, 2017

#493


This change is Reviewable

@iphydf
Copy link
Member

@iphydf iphydf commented Mar 5, 2017

Fascinating. Can you add a test case that fails without this change?

@iphydf iphydf added this to the v0.1.7 milestone Mar 5, 2017
@yurivict
Copy link
Member Author

@yurivict yurivict commented Mar 5, 2017

Are there any testcases of this kind? It requires 2 peers.

@nurupo
Copy link
Member

@nurupo nurupo commented Mar 6, 2017

Just create 2 Tox instances. Make sure to use tox_new_log() and ck_assert_msg(). You can find an empty test skeleton at auto_tests/skeleton_test.c.

@iphydf
Copy link
Member

@iphydf iphydf commented Mar 26, 2017

Please enable the checkbox "Allow edits from maintainers." on the bottom right.

@iphydf
Copy link
Member

@iphydf iphydf commented Mar 26, 2017

As nurupo said, create 2 tox instances and make them iterate() in the same loop.

@iphydf iphydf force-pushed the yurivict:fix-receipts branch from 3f2b3db to c097296 Apr 9, 2017
@iphydf
Copy link
Member

@iphydf iphydf commented Apr 12, 2017

@yurivict if you enable the checkbox, we can add the test case for you if you're unable to do so.

@iphydf iphydf modified the milestones: v0.1.9, v0.1.8 Apr 12, 2017
@yurivict
Copy link
Member Author

@yurivict yurivict commented Apr 12, 2017

"Allow edits from maintainers." is on.
Sorry, I can't do this right now.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jun 4, 2017

CLA assistant check
All committers have signed the CLA.

@iphydf
Copy link
Member

@iphydf iphydf commented Jun 4, 2017

I won't have time to add a test case. Once you're available again, please add one.

@iphydf iphydf modified the milestones: 0.1.10, v0.1.9 Jun 5, 2017
@robinlinden robinlinden modified the milestones: v0.1.11, v0.1.10 Aug 5, 2017
@iphydf
Copy link
Member

@iphydf iphydf commented Oct 3, 2017

Let's merge it with a TODO for a test case.

@robinlinden robinlinden force-pushed the yurivict:fix-receipts branch from 6a32c69 to d418e67 Oct 7, 2017
@robinlinden robinlinden removed this from the v0.1.11 milestone Dec 17, 2017
…ck never arrived.
@robinlinden robinlinden force-pushed the yurivict:fix-receipts branch from d418e67 to a3a22ae Dec 17, 2017
@robinlinden robinlinden added this to the v0.1.11 milestone Dec 17, 2017
@robinlinden
Copy link
Member

@robinlinden robinlinden commented Dec 17, 2017

:lgtm_strong:


Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@robinlinden robinlinden merged commit a3a22ae into TokTok:master Dec 17, 2017
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.