Build tests on appveyor, the MSVC build, but don't run them yet.

[iphydf]

---

This change is 

[Diadlo]

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

---

.travis.yml, line 3 at r1 (raw file):

language: c

# TODO(iphydf): Uncomment this before submitting.

It seems you forgot this ;)

---

Comments from Reviewable

[iphydf]

@Diadlo I'm still working on it.

[iphydf]

This is now ready for review.

[iphydf]

Review status: 0 of 26 files reviewed at latest revision, 1 unresolved discussion.

---

.travis.yml, line 3 at r1 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

It seems you forgot this ;)

Done.

---

Comments from Reviewable

[Diadlo]

Reviewed 28 of 28 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

appveyor.yml, line 11 at r2 (raw file):

- if not exist %APPDATA%\downloads mkdir %APPDATA%\downloads
# libcheck
- if not exist %APPDATA%\downloads\check.tar.gz curl -L https://github.com/libcheck/check/archive/0.11.0.zip -o %APPDATA%\downloads\check.zip

You check the existence of check.tar.gz but download check.zip

---

cmake/Dependencies.cmake, line 69 at r2 (raw file):

  find_library(LIBCHECK_LIBRARIES
    NAMES check libcheck
    PATHS "C:/Program Files (x86)/check/lib"

I think %ProgramFilesDir%/check/lib will be better. Same for other "Prgram Files (x86)"

---

Comments from Reviewable

[iphydf]

Review status: 25 of 27 files reviewed at latest revision, 2 unresolved discussions.

---

appveyor.yml, line 11 at r2 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

You checke the existence of check.tar.gz but download check.zip

Done.

---

cmake/Dependencies.cmake, line 69 at r2 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

I think %ProgramFilesDir%/check/lib will be better. Same for other "Prgram Files (x86)"

Done.

---

Comments from Reviewable

[nurupo]

CMakeLists.txt, line 397 at r2 (raw file):

      set_tests_properties(${target} PROPERTIES TIMEOUT "${TEST_TIMEOUT_SECONDS}")
    endif()
  endif()

Kind of weird how DISABLED test means "build=true, run=false", while MSVC_DISABLED means "build=false, run=false". One could think that MSVC_DISABLED does exactly what DISABLED does but only for MSVC and they would be wrong.

Perhaps changing DISABLED to DONT_RUN and MSVC_DISABLED to MSVC_DONT_BUILD, or to something along these lines, would be better? Alternatively, keeping DISABLED as it is but removing MSVC_DISABLED by pulling the if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") out of auto_test() would be fine too.

---

Comments from Reviewable

[nurupo]

cmake/Dependencies.cmake, line 69 at r2 (raw file):

Previously, iphydf wrote…

Done.

I don't understand what was wrong with using the working directory for everything and doing things relative to its path. You don't install libraries in Program Files on Windows. When you develop on Windows, all libraries your program depends on are usually in some directory called "deps" or "3rd-party" next to your source tree. You also ship the libraries together with your software product, so that when you install, say, qTox, all the libraries qTox depends on are in C:/Program Files (x86)/qTox, next to qTox.exe, not in C:/Program Files (x86)/tocore, C:/Program Files (x86)/opus, C:/Program Files (x86)/sodium, etc.

---

Comments from Reviewable

[nurupo]

Reviewed 28 of 28 files at r2.
Review status: 25 of 27 files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[iphydf]

Review status: 24 of 27 files reviewed at latest revision, 3 unresolved discussions.

---

CMakeLists.txt, line 397 at r2 (raw file):

Previously, nurupo wrote…

Kind of weird how DISABLED test means "build=true, run=false", while MSVC_DISABLED means "build=false, run=false". One could think that MSVC_DISABLED does exactly what DISABLED does but only for MSVC and they would be wrong.

Perhaps changing DISABLED to DONT_RUN and MSVC_DISABLED to MSVC_DONT_BUILD, or to something along these lines, would be better? Alternatively, keeping DISABLED as it is but removing MSVC_DISABLED by pulling the if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") out of auto_test() would be fine too.

Done.

---

cmake/Dependencies.cmake, line 69 at r2 (raw file):

Previously, nurupo wrote…

I don't understand what was wrong with using the working directory for everything and doing things relative to its path. You don't install libraries in Program Files on Windows. When you develop on Windows, all libraries your program depends on are usually in some directory called "deps" or "3rd-party" next to your source tree. You also ship the libraries together with your software product, so that when you install, say, qTox, all the libraries qTox depends on are in C:/Program Files (x86)/qTox, next to qTox.exe, not in C:/Program Files (x86)/tocore, C:/Program Files (x86)/opus, C:/Program Files (x86)/sodium, etc.

Added an explanation for it. I like to override defaults as little as possible.

---

Comments from Reviewable

[robinlinden]

---

Reviewed 22 of 28 files at r2, 6 of 6 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable