Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
forget DHT pubkey of offline friend after DHT timeout #615
The problem was as follows: if a friend goes offline for long enough, we stop
The reason that it took two disconnections for this to cause a problem is that
This PR zeroes out the friend's DHT PK when we delete them from the DHT, so the
requested review from
Nov 19, 2017
Oh, this would be a challenge for me. I guess I have to compile the c-toxcore library with TRifA or Antox but I have no cross-compile tool-chain until now.
* Tuesday, 2017-11-21 at 22:09 +0000 - toxtox <firstname.lastname@example.org>:
> Could you test to see if this does fix it? Oh, this would be a challenge for me. I guess I have to compile the c-toxcore library with TRifA or Antox but I have no cross-compile tool-chain until now.
Ah OK, I only asked because you mentioned having some tests for reproducing it. I tested it in toxic, and witnessed the problem and that this PR solved it. It'd be nice to have confirmation that it fixes it for others' setups too, but maybe it's not vital. I'm pretty sure this PR can't do any harm.