Make audio/video bit rates "properties" - #734
Merged
Merged
Conversation
Member
|
Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. toxav/toxav.api.h, line 479 at r1 (raw file):
"audio_bit_rate" is now just "bit_rate". See https://travis-ci.org/TokTok/c-toxcore/builds/334333799#L6208. toxav/toxav.api.h, line 525 at r1 (raw file):
"video_bit_rate" is now just "bit_rate". Comments from Reviewable |
Author
|
@iphydf that's too fast, i just saw that error... |
Member
|
Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
Member
|
Reviewed 2 of 4 files at r1, 2 of 2 files at r2. Comments from Reviewable |
follow #731. This commit completely removed all things in namespace bit_rate, and deprecated functions are to be added back in another commit. set_xxx() is treadted as a property of namespace audio&video, same as bit_rate change event. toxav_basic_test is fixed, either.
iphydf
approved these changes
Jan 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow #731. This commit
completely removed all things in namespace bit_rate, and deprecated
functions are to be added back in another commit. set_xxx() is treadted
as a property of namespace audio&video, same as bit_rate change event.
toxav_basic_test is fixed, either.
As for adding legacy functions back, it should be finished in #732.
This change is