Skip to content

Make audio/video bit rates "properties" - #734

Merged
iphydf merged 1 commit into
TokTok:masterfrom
xhebox:master
Jan 28, 2018
Merged

Make audio/video bit rates "properties"#734
iphydf merged 1 commit into
TokTok:masterfrom
xhebox:master

Conversation

@xhebox

@xhebox xhebox commented Jan 28, 2018

Copy link
Copy Markdown

follow #731. This commit
completely removed all things in namespace bit_rate, and deprecated
functions are to be added back in another commit. set_xxx() is treadted
as a property of namespace audio&video, same as bit_rate change event.

toxav_basic_test is fixed, either.

As for adding legacy functions back, it should be finished in #732.


This change is Reviewable

@xhebox
xhebox requested a review from iphydf January 28, 2018 11:21
@xhebox xhebox self-assigned this Jan 28, 2018
@iphydf

iphydf commented Jan 28, 2018

Copy link
Copy Markdown
Member

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


toxav/toxav.api.h, line 479 at r1 (raw file):

     * @param friend_number The friend number of the friend for which to set the
     * bit rate.
     * @param audio_bit_rate The new audio bit rate in Kb/sec. Set to 0 to disable.

"audio_bit_rate" is now just "bit_rate".

See https://travis-ci.org/TokTok/c-toxcore/builds/334333799#L6208.


toxav/toxav.api.h, line 525 at r1 (raw file):

     * @param friend_number The friend number of the friend for which to set the
     * bit rate.
     * @param video_bit_rate The new video bit rate in Kb/sec. Set to 0 to disable.

"video_bit_rate" is now just "bit_rate".


Comments from Reviewable

@xhebox

xhebox commented Jan 28, 2018

Copy link
Copy Markdown
Author

@iphydf that's too fast, i just saw that error...

@iphydf

iphydf commented Jan 28, 2018

Copy link
Copy Markdown
Member

:lgtm_strong:


Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

@iphydf

iphydf commented Jan 28, 2018

Copy link
Copy Markdown
Member

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

follow #731. This commit
completely removed all things in namespace bit_rate, and deprecated
functions are to be added back in another commit. set_xxx() is treadted
as a property of namespace audio&video, same as bit_rate change event.

toxav_basic_test is fixed, either.
@iphydf
iphydf merged commit 651ef3a into TokTok:master Jan 28, 2018
@iphydf iphydf added this to the v0.2.0 milestone Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants