New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audio/video bit rates "properties" #734

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
2 participants
@xhebox
Copy link

xhebox commented Jan 28, 2018

follow #731. This commit
completely removed all things in namespace bit_rate, and deprecated
functions are to be added back in another commit. set_xxx() is treadted
as a property of namespace audio&video, same as bit_rate change event.

toxav_basic_test is fixed, either.

As for adding legacy functions back, it should be finished in #732.


This change is Reviewable

@xhebox xhebox requested a review from iphydf Jan 28, 2018

@xhebox xhebox self-assigned this Jan 28, 2018

@iphydf

This comment has been minimized.

Copy link
Member

iphydf commented Jan 28, 2018

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


toxav/toxav.api.h, line 479 at r1 (raw file):

     * @param friend_number The friend number of the friend for which to set the
     * bit rate.
     * @param audio_bit_rate The new audio bit rate in Kb/sec. Set to 0 to disable.

"audio_bit_rate" is now just "bit_rate".

See https://travis-ci.org/TokTok/c-toxcore/builds/334333799#L6208.


toxav/toxav.api.h, line 525 at r1 (raw file):

     * @param friend_number The friend number of the friend for which to set the
     * bit rate.
     * @param video_bit_rate The new video bit rate in Kb/sec. Set to 0 to disable.

"video_bit_rate" is now just "bit_rate".


Comments from Reviewable

@xhebox

This comment has been minimized.

Copy link
Author

xhebox commented Jan 28, 2018

@iphydf that's too fast, i just saw that error...

@iphydf

This comment has been minimized.

Copy link
Member

iphydf commented Jan 28, 2018

:lgtm_strong:


Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

@iphydf

This comment has been minimized.

Copy link
Member

iphydf commented Jan 28, 2018

Reviewed 2 of 4 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


Comments from Reviewable

@iphydf iphydf force-pushed the xhebox:master branch from 9a9256b to 60657ab Jan 28, 2018

Make audio/video bit rates "properties"
follow #731. This commit
completely removed all things in namespace bit_rate, and deprecated
functions are to be added back in another commit. set_xxx() is treadted
as a property of namespace audio&video, same as bit_rate change event.

toxav_basic_test is fixed, either.

@iphydf iphydf force-pushed the xhebox:master branch from 60657ab to 651ef3a Jan 28, 2018

@iphydf

iphydf approved these changes Jan 28, 2018

@iphydf iphydf merged commit 651ef3a into TokTok:master Jan 28, 2018

4 of 5 checks passed

ci/circleci CircleCI is running your tests
Details
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@iphydf iphydf added this to the v0.2.0 milestone Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment