Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the "change occurred" API change from isotoxin-groupchat. #771

Merged
merged 1 commit into from Feb 9, 2018

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Feb 8, 2018

The logic and behaviour remain the same, but PEER_EXIT and PEER_JOIN are
merged into LIST_CHANGED. This allows clients to take a first step to
adapt to the API change without us having to actually submit the full
change, yet.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Feb 8, 2018
@iphydf iphydf force-pushed the iphydf:peerlist-event branch 2 times, most recently from 7678bfb to 5f9ecba Feb 8, 2018
@tox-user
Copy link
Member

@tox-user tox-user commented Feb 8, 2018

:lgtm_strong:


Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

The logic and behaviour remain the same, but PEER_EXIT and PEER_JOIN are
merged into LIST_CHANGED. This allows clients to take a first step to
adapt to the API change without us having to actually submit the full
change, yet.
@iphydf iphydf force-pushed the iphydf:peerlist-event branch from 5f9ecba to a940f26 Feb 9, 2018
@iphydf iphydf merged commit a940f26 into TokTok:master Feb 9, 2018
6 of 7 checks passed
6 of 7 checks passed
ci/circleci CircleCI is running your tests
Details
GPG All commits have a verified GPG signature
WIP ready for review
Details
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@iphydf iphydf deleted the iphydf:peerlist-event branch Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants