Skip to content

Adopt the "change occurred" API change from isotoxin-groupchat. - #771

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:peerlist-event
Feb 9, 2018
Merged

Adopt the "change occurred" API change from isotoxin-groupchat.#771
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:peerlist-event

Conversation

@iphydf

@iphydf iphydf commented Feb 8, 2018

Copy link
Copy Markdown
Member

The logic and behaviour remain the same, but PEER_EXIT and PEER_JOIN are
merged into LIST_CHANGED. This allows clients to take a first step to
adapt to the API change without us having to actually submit the full
change, yet.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Feb 8, 2018
@iphydf
iphydf force-pushed the peerlist-event branch 2 times, most recently from 7678bfb to 5f9ecba Compare February 8, 2018 17:26
@tox-user

tox-user commented Feb 8, 2018

Copy link
Copy Markdown
Member

:lgtm_strong:


Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

The logic and behaviour remain the same, but PEER_EXIT and PEER_JOIN are
merged into LIST_CHANGED. This allows clients to take a first step to
adapt to the API change without us having to actually submit the full
change, yet.
@iphydf
iphydf merged commit a940f26 into TokTok:master Feb 9, 2018
@iphydf
iphydf deleted the peerlist-event branch February 9, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants