Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "persistent conference" callback changes as new functions. #799

Merged
merged 1 commit into from Feb 20, 2018

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Feb 19, 2018

We can now revert the changes to the callbacks and keep supporting them
until clients have moved off them.


This change is Reviewable

@iphydf iphydf force-pushed the iphydf:gc-callbacks branch from 62ea20b to cb90e83 Feb 19, 2018
@iphydf iphydf added this to the v0.2.0 milestone Feb 19, 2018
@iphydf iphydf changed the title Make the "persistent conference" callback changes new functions. Implement the "persistent conference" callback changes as new functions. Feb 19, 2018
@iphydf iphydf force-pushed the iphydf:gc-callbacks branch 4 times, most recently from dce19de to 9124821 Feb 19, 2018
@sudden6
Copy link

@sudden6 sudden6 commented Feb 20, 2018

Reviewed 4 of 7 files at r1, 3 of 3 files at r2.
Review status: 5 of 7 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sudden6
Copy link

@sudden6 sudden6 commented Feb 20, 2018

:lgtm_strong:


Review status: 5 of 7 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

We can now revert the changes to the callbacks and keep supporting them
until clients have moved off them.
@iphydf iphydf force-pushed the iphydf:gc-callbacks branch from 9124821 to 95c03e0 Feb 20, 2018
@iphydf iphydf merged commit 95c03e0 into TokTok:master Feb 20, 2018
6 of 7 checks passed
6 of 7 checks passed
ci/circleci CircleCI is running your tests
Details
GPG All commits have a verified GPG signature
WIP ready for review
Details
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@iphydf iphydf deleted the iphydf:gc-callbacks branch Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants