Skip to content

Implement the "persistent conference" callback changes as new functions. - #799

Merged
iphydf merged 1 commit into
TokTok:masterfrom
iphydf:gc-callbacks
Feb 20, 2018
Merged

iphydf merged 1 commit into
TokTok:masterfrom
iphydf:gc-callbacks

Conversation

@iphydf

@iphydf iphydf commented Feb 19, 2018 •

Copy link
Copy Markdown
Member

We can now revert the changes to the callbacks and keep supporting them
until clients have moved off them.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Feb 19, 2018
@iphydf iphydf changed the title Make the "persistent conference" callback changes new functions. Implement the "persistent conference" callback changes as new functions. Feb 19, 2018
@iphydf
iphydf force-pushed the gc-callbacks branch 4 times, most recently from dce19de to 9124821 Compare February 20, 2018 21:22
@sudden6

sudden6 commented Feb 20, 2018

Copy link
Copy Markdown

Reviewed 4 of 7 files at r1, 3 of 3 files at r2.
Review status: 5 of 7 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sudden6

sudden6 commented Feb 20, 2018

Copy link
Copy Markdown

:lgtm_strong:


Review status: 5 of 7 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

We can now revert the changes to the callbacks and keep supporting them
until clients have moved off them.
@iphydf
iphydf merged commit 95c03e0 into TokTok:master Feb 20, 2018
@iphydf
iphydf deleted the gc-callbacks branch February 20, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants