Call the "peer leaves" callback only once on group delete. #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudden6
approved these changes
Jul 7, 2018
There was a problem hiding this comment.
this change itself makes sense atm, but in the future it would be nice to have some sort of identification for the peer that left
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @sudden6)
sudden6
approved these changes
Jul 7, 2018
complete! 1 of 1 LGTMs obtainedWe used to pass the actual peer numbers of peers leaving, but we no longer know these in the PGC world, so we don't pass them anymore.
iphydf
force-pushed
the
group-leave-cb-once
branch
from
b3308c5
to
08ff19a
Compare
|
This is not breaking any public api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to pass the actual peer numbers of peers leaving, but we no
longer know these in the PGC world, so we don't pass them anymore.
This change is