Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conference_get_id function #36

Merged
merged 1 commit into from Sep 23, 2018
Merged

Add conference_get_id function #36

merged 1 commit into from Sep 23, 2018

Conversation

@tox-user
Copy link
Member

tox-user commented Aug 17, 2018

Adds a function to get group's unique ID


This change is Reviewable

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Aug 17, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iphydf

This comment has been minimized.

Copy link
Member

iphydf commented Aug 17, 2018

Please rebase on master.

@tox-user tox-user force-pushed the tox-user:conference_id branch from 555c4f7 to a22933d Aug 17, 2018
@iphydf iphydf force-pushed the tox-user:conference_id branch from a22933d to a79b470 Sep 9, 2018
@iphydf iphydf force-pushed the tox-user:conference_id branch 6 times, most recently from bbcde98 to 555345b Sep 22, 2018
Adds a function to get group's unique ID.
@iphydf iphydf force-pushed the tox-user:conference_id branch from 555345b to c024aab Sep 22, 2018
@iphydf iphydf self-requested a review Sep 23, 2018
@iphydf
iphydf approved these changes Sep 23, 2018
Copy link
Member

iphydf left a comment

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @iphydf)

@iphydf iphydf merged commit c024aab into TokTok:master Sep 23, 2018
8 of 9 checks passed
8 of 9 checks passed
license/cla Contributor License Agreement is not signed yet.
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
Docker Build Task Summary
Details
WIP ready for review
Details
ci/circleci: asan Your tests passed on CircleCI!
Details
code-review/reviewable 1 of 1 ✓
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on conference_id at 63.463%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.