Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types Definition #333

Merged
merged 14 commits into from
Feb 1, 2021
Merged

Types Definition #333

merged 14 commits into from
Feb 1, 2021

Conversation

josh-hemphill
Copy link
Contributor

Fixes #155

Finally figured it out. The answer was tsd-jsdoc! It uses the type information returned by jsdoc to create a .d.ts file.

If anyone knows of a TS project using this library, I think the first step to using this would be to have them manually reference the definitions file to test it. That way we can publish without linking it in package.json and avoid breaking anything but still let people use it.

Changes proposed in this pull request:

  • Add type definitions for canvas-datagrid.js

@josh-hemphill josh-hemphill changed the title Ts tests Types Definition Dec 11, 2020
@ndrsn
Copy link
Collaborator

ndrsn commented Dec 11, 2020

Great work! Could you please fix the indentation on package.json so the diff is more useful?

@ndrsn ndrsn merged commit b29115c into TonyGermaneri:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript typings?
2 participants