Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Node.js >= 10.0.0 #73

Closed
wants to merge 3 commits into from

Conversation

@lpinca
Copy link
Contributor

@lpinca lpinca commented Jul 26, 2019

Resume the socket after the 'socket' event is emitted on the
ClientRequest object.

Refs: nodejs/node#24474 (comment)
Fixes: #58

lpinca added 3 commits Jul 26, 2019
Node.js < 4.5.0 is no longer supported as per
TooTallNate@a277922.
Resume the socket after the `'socket'` event is emitted on the
`ClientRequest` object.

Refs: nodejs/node#24474 (comment)
Fixes: TooTallNate#58
@lpinca
Copy link
Contributor Author

@lpinca lpinca commented Jul 26, 2019

Depends on TooTallNate/proxy#14.

@lpinca
Copy link
Contributor Author

@lpinca lpinca commented Aug 31, 2019

@TooTallNate @sadasant ping. Are you interested in this?

TooTallNate added a commit that referenced this issue Oct 4, 2019
Resume the socket after the `'socket'` event is emitted on the
`ClientRequest` object.

Fixes: #58
Refs: nodejs/node#24474 (comment)
@TooTallNate
Copy link
Owner

@TooTallNate TooTallNate commented Oct 4, 2019

Thanks @ianhowe76!

@TooTallNate TooTallNate closed this Oct 4, 2019
@lpinca lpinca deleted the support/node-10 branch Oct 4, 2019
@lpinca
Copy link
Contributor Author

@lpinca lpinca commented Oct 4, 2019

@TooTallNate thanks, can you cut a new release when you can?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants