Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an EventEmitter to replay failed proxy connect HTTP requests #77

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@TooTallNate
Copy link
Owner

@TooTallNate TooTallNate commented Oct 4, 2019

This is a fix for https://hackerone.com/reports/541502.

Aborts the upstream proxy connection and instead uses a vanilla EventEmitter instance to replay the "data" events on to. This way, the node core http Client doesn't attempt to write the HTTP request that is intended to go to the destination server to the proxy server.

Closes #76.
Fixes #78.

TooTallNate added 2 commits Oct 4, 2019
This is a fix for https://hackerone.com/reports/541502.

Aborts the upstream proxy connection and instead uses a vanilla
`EventEmitter` instance to replay the "data" events on to. This way,
the node core `http` Client doesn't attempt to write the HTTP request
that is intended to go to the destination server to the proxy server.

Closes #76.
@TooTallNate TooTallNate force-pushed the fix/hackerone.com/reports/541502 branch from 8df8813 to d9eb617 Oct 4, 2019
@kadler15
Copy link

@kadler15 kadler15 commented Oct 7, 2019

Tested. Looks good!

image

@TooTallNate TooTallNate merged commit 36d8cf5 into master Oct 7, 2019
2 checks passed
@TooTallNate TooTallNate deleted the fix/hackerone.com/reports/541502 branch Oct 7, 2019
@TooTallNate
Copy link
Owner Author

@TooTallNate TooTallNate commented Oct 7, 2019

Thanks for the review. Published as v3.0.0.

TooTallNate added a commit to TooTallNate/node-pac-proxy-agent that referenced this issue Oct 15, 2019
TooTallNate added a commit to TooTallNate/node-proxy-agent that referenced this issue Oct 15, 2019
feelepxyz added a commit to feelepxyz/security-wg that referenced this issue Nov 18, 2019
MarcinHoppe added a commit to nodejs/security-wg that referenced this issue Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants