Skip to content
This repository

Fixed global variable "plist" leak #24

Merged
merged 1 commit into from about 1 year ago

2 participants

Vladimir Tsvang Mike Reinstein
Vladimir Tsvang

When calling plist.parseStringSync it overwrites value of plist globally. It is because var is missing.

Mike Reinstein mreinstein merged commit 4b96b7c into from January 30, 2013
Mike Reinstein mreinstein closed this January 30, 2013
Mike Reinstein
Collaborator

thanks @vtsvang, good catch!

Vladimir Tsvang vtsvang deleted the branch January 30, 2013
Vladimir Tsvang

Many thanks for the fast merge! May I ask you to bump package version?
Thanks in advance.

Mike Reinstein
Collaborator

Yes I plan to tomorrow. It's 3:17am here and I don't like to push changes to production when I'm tired. :)

Vladimir Tsvang

Great, thanks!

Mike Reinstein
Collaborator

@vtsvang done! Keep those patches rolling in! :)

Vladimir Tsvang

@mreinstein Brilliant! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jan 30, 2013
Vladimir Tsvang Fixed global variable plist leak a040e22
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 0 deletions. Show diff stats Hide diff stats

  1. 1  lib/plist.js
1  lib/plist.js
@@ -75,6 +75,7 @@
75 75
 
76 76
 	exports.parseStringSync = function (xml) {
77 77
 		var doc = new DOMParser().parseFromString(xml);
  78
+    var plist;
78 79
 		if (doc.documentElement.nodeName !== 'plist') {
79 80
 			throw new Error('malformed document. First element should be <plist>');
80 81
 		}
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.