New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from using socks-client to socks #5

Merged
merged 3 commits into from Mar 2, 2015

Conversation

Projects
None yet
2 participants
@JoshGlazebrook
Contributor

JoshGlazebrook commented Feb 26, 2015

I recently acquired the "socks" npm package and have renamed my "socks-client" that you are using to "socks". I've added a deprecation message to all socks-client versions but I will be leaving the package itself it up for foreseeable future. However all new features and bug fixes will be published under the socks name.

Show outdated Hide outdated package.json Outdated
Show outdated Hide outdated package.json Outdated
@JoshGlazebrook

This comment has been minimized.

Show comment
Hide comment
@JoshGlazebrook

JoshGlazebrook Feb 26, 2015

Contributor

Well the socks package itself was only at 0.0.1, I thought it would be a better idea to just start at 1.0.0 as it's a completely different name that people would manually need to change to anyways. Do you think it would be better to keep the same version numbers instead?

Contributor

JoshGlazebrook commented Feb 26, 2015

Well the socks package itself was only at 0.0.1, I thought it would be a better idea to just start at 1.0.0 as it's a completely different name that people would manually need to change to anyways. Do you think it would be better to keep the same version numbers instead?

@JoshGlazebrook

This comment has been minimized.

Show comment
Hide comment
@JoshGlazebrook

JoshGlazebrook Feb 26, 2015

Contributor

Actually now that I think about it, it does make more sense to continue the versioning I had in place as the repo on github still has the release numbers from when it was still socks-client. I'll change it.

Contributor

JoshGlazebrook commented Feb 26, 2015

Actually now that I think about it, it does make more sense to continue the versioning I had in place as the repo on github still has the release numbers from when it was still socks-client. I'll change it.

@TooTallNate

This comment has been minimized.

Show comment
Hide comment
@TooTallNate

TooTallNate Feb 26, 2015

Owner

Sweet. Sounds good. Thanks for the PR btw! socks is a sweet package name, nice score.

Owner

TooTallNate commented Feb 26, 2015

Sweet. Sounds good. Thanks for the PR btw! socks is a sweet package name, nice score.

TooTallNate added a commit that referenced this pull request Mar 2, 2015

@TooTallNate TooTallNate merged commit 604c61a into TooTallNate:master Mar 2, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@TooTallNate

This comment has been minimized.

Show comment
Hide comment
@TooTallNate

TooTallNate Mar 2, 2015

Owner

Thanks!

Owner

TooTallNate commented Mar 2, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment