Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Chaining setTimezone() #34

Merged
merged 1 commit into from Mar 6, 2013

Conversation

Projects
None yet
2 participants
Contributor

Atinux commented Mar 5, 2013

Hi :)

I just add return this; at the end of setTimezone() method.

With that, we can do :

  var now = new time.Date().setTimezone("America/Los_Angeles");

Thanks for you awesome module :)

Chaining setTimezone()
Hi :)

I just add `return this;` at the end of setTimezone() method.

With that, we can do :
<pre>
  var now = new time.Date().setTimezone("America/Los_Angeles");
</pre>

Thanks for you awesome module :)
Owner

TooTallNate commented Mar 6, 2013

Seems ok to me. Would you mind adding a test case?

TooTallNate added a commit that referenced this pull request Mar 6, 2013

@TooTallNate TooTallNate merged commit 5bdac21 into TooTallNate:master Mar 6, 2013

1 check passed

default The Travis build passed
Details
Contributor

Atinux commented Mar 6, 2013

Yep of course, here the pull request: #35

(I don't know why this time it created a second pull request...sorry).

Don't forget to bump the package.json version and to publish on npm :)

@Atinux Atinux deleted the Atinux:patch-1 branch Mar 6, 2013

Owner

TooTallNate commented Mar 6, 2013

Kewl, thanks. Merged and published as v0.9.0.

Contributor

Atinux commented Mar 6, 2013

Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment