Permalink
Browse files

Include the node.lib file at link time on Windows.

Makes the basic `gyp_addon` script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...
  • Loading branch information...
1 parent 4228112 commit 43212f4de33bc995be1c13fa768b3ef1e0e3fac1 @TooTallNate committed Jan 6, 2012
Showing with 4 additions and 0 deletions.
  1. +3 −0 tools/addon.gypi
  2. +1 −0 tools/gyp_addon
View
@@ -12,6 +12,9 @@
'conditions': [
[ 'OS=="mac"', {
'libraries': [ '-undefined dynamic_lookup' ],
+ }],
+ [ 'OS=="win"', {
+ 'libraries': [ '-l<(node_root_dir>/Debug/node.lib' ],
}]
]
}
View
@@ -16,6 +16,7 @@ if __name__ == '__main__':
args.extend(['-I', common_gypi])
args.extend(['-Dlibrary=shared_library'])
args.extend(['-Dvisibility=default'])
+ args.extend(['-Dnode_root_dir=%s' % node_root])
args.extend(['--depth=.']);
gyp_args = list(args)

0 comments on commit 43212f4

Please sign in to comment.