Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Also make sure Windows works when building in "out".

  • Loading branch information...
commit c5357e38549653b3a2d80ee263f41df304f638aa 1 parent b99fb31
Nathan Rajlich authored
Showing with 7 additions and 3 deletions.
  1. +7 −3 tools/gyp_addon
10 tools/gyp_addon
View
@@ -3,7 +3,11 @@ import os
import sys
script_dir = os.path.dirname(__file__)
-node_root = os.path.normpath(os.path.join(script_dir, os.pardir))
+node_root = os.path.abspath(os.path.join(script_dir, os.pardir))
+if sys.platform == 'win32':
+ output_dir = os.path.join(os.getcwd(), 'out')
+else:
+ output_dir = 'out'
sys.path.insert(0, os.path.join(node_root, 'tools', 'gyp', 'pylib'))
import gyp
@@ -22,8 +26,8 @@ if __name__ == '__main__':
args.extend(['-Dnode_root_dir=%s' % node_root])
args.extend(['--depth=.']);
- # Tell gyp to write the Makefiles into output_dir
- args.extend(['--generator-output', 'out'])
+ # Tell gyp to write the Makefile/Solution files into output_dir
+ args.extend(['--generator-output', output_dir])
# Tell make to write its output into the same dir
args.extend(['-Goutput_dir=.'])
Please sign in to comment.
Something went wrong with that request. Please try again.