Permalink
Browse files

repl: fix 'terminal' mode autodetection on global repls

Fixes test/simple/test-force-repl.js
  • Loading branch information...
1 parent aad12d0 commit 698e795a5ffb617c5a3e3e79de7dfdd0ce637695 @TooTallNate committed Mar 27, 2012
Showing with 12 additions and 7 deletions.
  1. +6 −3 lib/_debugger.js
  2. +6 −4 src/node.js
View
@@ -747,15 +747,18 @@ function Interface(stdin, stdout, args) {
// Two eval modes are available: controlEval and debugEval
// But controlEval is used by default
- this.repl = repl.start({
+ var opts = {
prompt: 'debug> ',
input: this.stdin,
output: this.stdout,
- terminal: !parseInt(process.env['NODE_NO_READLINE'], 10),
eval: this.controlEval.bind(this),
useGlobal: false,
ignoreUndefined: true
- });
+ };
+ if (parseInt(process.env['NODE_NO_READLINE'], 10)) {
+ opts.terminal = false;
+ }
+ this.repl = repl.start(opts);
// Do not print useless warning
repl._builtinLibs.splice(repl._builtinLibs.indexOf('repl'), 1);
View
@@ -121,12 +121,14 @@
// If -i or --interactive were passed, or stdin is a TTY.
if (process._forceRepl || NativeModule.require('tty').isatty(0)) {
// REPL
- var repl = Module.requireRepl().start({
- prompt: '> ',
- terminal: !parseInt(process.env['NODE_NO_READLINE'], 10),
+ var opts = {
useGlobal: true,
ignoreUndefined: false
- });
+ };
+ if (parseInt(process.env['NODE_NO_READLINE'], 10)) {
+ opts.terminal = false;
+ }
+ var repl = Module.requireRepl().start(opts);
repl.on('exit', function() {
process.exit();
});

0 comments on commit 698e795

Please sign in to comment.