Fixed global variable "plist" leak #24

Merged
merged 1 commit into from Jan 30, 2013

2 participants

@vtsvang

When calling plist.parseStringSync it overwrites value of plist globally. It is because var is missing.

@mreinstein mreinstein merged commit 4b96b7c into TooTallNate:master Jan 30, 2013
@mreinstein
Collaborator

thanks @vtsvang, good catch!

@vtsvang vtsvang deleted the vtsvang:support/fix-global-variable-leak branch Jan 30, 2013
@vtsvang

Many thanks for the fast merge! May I ask you to bump package version?
Thanks in advance.

@mreinstein
Collaborator

Yes I plan to tomorrow. It's 3:17am here and I don't like to push changes to production when I'm tired. :)

@vtsvang

Great, thanks!

@mreinstein
Collaborator

@vtsvang done! Keep those patches rolling in! :)

@vtsvang

@mreinstein Brilliant! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment