Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed global variable "plist" leak #24

Merged
merged 1 commit into from Jan 30, 2013

Conversation

Projects
None yet
2 participants
Contributor

vtsvang commented Jan 30, 2013

When calling plist.parseStringSync it overwrites value of plist globally. It is because var is missing.

@mreinstein mreinstein added a commit that referenced this pull request Jan 30, 2013

@mreinstein mreinstein Merge pull request #24 from vtsvang/support/fix-global-variable-leak
Fixed global variable "plist" leak
4b96b7c

@mreinstein mreinstein merged commit 4b96b7c into TooTallNate:master Jan 30, 2013

Collaborator

mreinstein commented Jan 30, 2013

thanks @vtsvang, good catch!

@vtsvang vtsvang deleted the vtsvang:support/fix-global-variable-leak branch Jan 30, 2013

Contributor

vtsvang commented Jan 30, 2013

Many thanks for the fast merge! May I ask you to bump package version?
Thanks in advance.

Collaborator

mreinstein commented Jan 30, 2013

Yes I plan to tomorrow. It's 3:17am here and I don't like to push changes to production when I'm tired. :)

Contributor

vtsvang commented Jan 30, 2013

Great, thanks!

Collaborator

mreinstein commented Jan 30, 2013

@vtsvang done! Keep those patches rolling in! :)

Contributor

vtsvang commented Jan 31, 2013

@mreinstein Brilliant! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment