src: allow Buffers returned from reinterpretUntilZeros() up to `kMa…

…xLength` bytes

Fixes a bug where the returned Buffer could have truncated data.

Reported via email by Adam Mansour (@intelligo).

src/binding.cc

@@ -546,7 +546,7 @@ NAN_METHOD(ReinterpretBufferUntilZeros) {
   size_t size = 0;
   bool end = false;
 
-  while (!end && size < 10000) {
+  while (!end && size < node::Buffer::kMaxLength) {
     end = true;
     for (i = 0; i < numZeros; i++) {
       if (ptr[size + i] != 0) {

test/reinterpretUntilZeros.js

@@ -1,4 +1,5 @@
 
+var fs = require('fs')
 var assert = require('assert')
 var weak = require('weak')
 var ref = require('../')
@@ -25,4 +26,12 @@ describe('reinterpretUntilZeros()', function () {
     assert.equal(buf2.toString('ucs2'), str)
   })
 
+  it('should return a large Buffer instance > 10,000 bytes with UTF16-LE char bytes', function () {
+    var data = fs.readFileSync(__dirname + '/utf16le.bin');
+    var strBuf = ref.reinterpretUntilZeros(data, 2);
+    assert(strBuf.length > 10000);
+    // the data in `utf16le.bin` should be a JSON parsable string
+    JSON.parse(strBuf.toString('utf16le'));
+  })
+
 })