Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss Main Section implementation #146

Open
dmansdman opened this issue Mar 28, 2022 · 1 comment
Open

Discuss Main Section implementation #146

dmansdman opened this issue Mar 28, 2022 · 1 comment
Assignees
@ewang2002 @dmansdman
Labels
c-gen sections Category: Main/Other Sections g-help wanted General: Extra attention is needed it-enhancement Issue Type: Enhancement (new feature or request)
Milestone
Version 1.4.0: Da...

Comments

@dmansdman
Copy link
Contributor

The main section is evidently a relic of a time before sections were implemented. This has resulted in numerous instances where logic is checking if section is main versus if it is any other section. It seems like this leads to main being unnecessary, since it could be implemented as another section instead. This would also clean up iguildinfo a little bit, since a lot of its fields are section-fields but dedicated to main. This issue is simply to discuss the ramifications and whether we wish to do this.
@dmansdman dmansdman added it-enhancement Issue Type: Enhancement (new feature or request) g-help wanted General: Extra attention is needed major labels Mar 28, 2022
@dmansdman dmansdman added this to the Version 1.3.0: Internal/Performance Fixes milestone Mar 28, 2022
@dmansdman
Copy link
Contributor Author

Linking to 1.3, not a priority atm.

@ewang2002 ewang2002 added c-gen sections Category: Main/Other Sections and removed major labels Jul 4, 2022
@ewang2002 ewang2002 removed this from the Version 1.3.0: Internal/Performance Fixes milestone Jul 11, 2022
@ewang2002 ewang2002 linked a pull request Aug 28, 2022 that will close this issue
refactor(db): complete guild database restructure #235
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewang2002 ewang2002

@dmansdman dmansdman

Labels
c-gen sections Category: Main/Other Sections g-help wanted General: Extra attention is needed it-enhancement Issue Type: Enhancement (new feature or request)
Projects
None yet
Milestone
Version 1.4.0: Database Restructuring
Development

Successfully merging a pull request may close this issue.

refactor(db): complete guild database restructure ToogaInc/ToogaBooga
2 participants
@ewang2002 @dmansdman