generate css with travis #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually this could work. We will see...
|
Issue #220 |
This don't need a extra script for minify css
Now lektor detects if the file is local available. If it is, it will use it. If not, it will use the remote file and linking to the local font folders, because not every browser will accept the remote fonts that easy on localhost.
DO1JLR
added
Please Review
|
I already searched the function to check if a file exists locally but could not find it glad you found one :) |
maxbachmann
dismissed
their stale review
just tested the new description and lektor clear does not work for me
|
ah already though the lektor clear is wrong :) |
lektor does not trigger a new build only if a file like main.min.css suddenly appear or dissappear. It need a manual trigger like deleting the cache or modify the templeates. make will now delete the cache.
Should be fixed with 9cf1b86, we will see what travis will say! |
I am happy about this too. |
|
well we only need to check for assets anyways |
maxbachmann
approved these changes
Feb 15, 2019
wolf128058
pushed a commit
that referenced
this pull request
Sep 24, 2019
* generate css with travis Eventually this could work. We will see... * sassc -> sass * Travis need sudo * use ruby-sass * Use sass -t compress This don't need a extra script for minify css * delete old python script * make deployment optional * prepare travis switch to show this is live system * new method including the css Now lektor detects if the file is local available. If it is, it will use it. If not, it will use the remote file and linking to the local font folders, because not every browser will accept the remote fonts that easy on localhost. * Expand sass explaination * improve lektor locale css config lektor does not trigger a new build only if a file like main.min.css suddenly appear or dissappear. It need a manual trigger like deleting the cache or modify the templeates. make will now delete the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually this could work. We will see...
The script from @ottojo probably won't generate css.