Toot Stream Updates #113
Merged
Toot Stream Updates #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for discussion over at https://github.com/TootSDK/TootSDK/discussions/104
Specifically this addresses:
✅ How to handle errors of misconfigured parameters if we used generic ones (we check the type of query params supplied and return an error if the wrong type is used)
✅ How to ensure call sites are 'clean'. e.g if you're running on defaults it can look something like: client.data.stream(.timeLineHome)
✅ Ensuring that the TootStream private dictionary where it caches requested streams, has a unique key for the stream type + params.
This does not cover:
How would we like the Mastodon streaming API to interact with TootStream? (I figure this can be a separate PR after this one is discussed/merged!)