Skip to content

✨ allows for default package configuration #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2018
Merged

✨ allows for default package configuration #119

merged 2 commits into from
Sep 21, 2018

Conversation

@acidjazz
Copy link
Contributor

@acidjazz acidjazz commented Sep 4, 2018 •
edited
Loading

this fixes #100 by adding mergeConfigFrom allowing the package to work w/out a config as documented here

@acidjazz acidjazz mentioned this pull request Sep 4, 2018
Closed
@acidjazz
Copy link
Contributor Author

acidjazz commented Sep 13, 2018

@Torann had time to take a look yet? my packages are waiting :)

@Torann Torann merged commit 948617d into Torann:master Sep 21, 2018
@acidjazz acidjazz deleted the master branch September 21, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The GeoIP service is not valid.

2 participants

@acidjazz @Torann