Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category Restructure #6

Merged
merged 18 commits into from
Oct 28, 2018
Merged

Category Restructure #6

merged 18 commits into from
Oct 28, 2018

Conversation

Tornquist
Copy link
Owner

💚 Summary

I did:

  • Replaced existing parent_id tree structure with a controlled nested set model. This includes the addition of a handful of stored procedures to:
    • Visualize a category tree
    • Manage the setup of accounts (and root nodes)
    • Manage the movement of nodes between accounts and within trees
    • Manage the addition of new nodes
    • Manage the deletion of nodes (with optional child handling)
  • Updated Account and Category module to repair old tests
  • Added nested set test suite. It's JS, but uses raw sql through Knex to execute the new procedures

I did not:

  • Add new category methods to manage the movement, deletion, etc. These changes are just a restructuring of what was already there. --> The unused category procedures are in place to verify the nested set model, and are tested as such.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 62

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.707%

Totals Coverage Status
Change from base Build 41: 0.03%
Covered Lines: 432
Relevant Lines: 442

💛 - Coveralls

@Tornquist
Copy link
Owner Author

👍

@Tornquist Tornquist merged commit f89da12 into master Oct 28, 2018
@Tornquist Tornquist deleted the category_restructure branch October 28, 2018 14:46
@Tornquist Tornquist mentioned this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants