Updates the torsion.in file to properly be configured to handle tscript extension #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffProgrammer
approved these changes
Mar 27, 2021
lukaspj
added
C++
|
@Areloch Does the CMake build system have a variable that sets the TS script extension? Since this is a cmake.in file, we should use that variable instead of hardcoding it if it does. If it doesn't, then this is good to merge. |
|
Ah yeah that makes sense. It does have such a variable |
Azaezel
reviewed
May 11, 2021
Tools/CMake/template.torsion.in
Outdated
| @@ -1,18 +1,14 @@ | |||
| <TorsionProject> | |||
| <Name>@TORQUE_APP_NAME@</Name> | |||
| <WorkingDir/> | |||
| <EntryScript>main.cs</EntryScript> | |||
| <EntryScript>main.tscript</EntryScript> | |||
There was a problem hiding this comment.
<EntryScript>main.@TORQUE_SCRIPT_EXTENSION@</EntryScript>
Azaezel
reviewed
May 11, 2021
Tools/CMake/template.torsion.in
Outdated
| <Folder>data</Folder> | ||
| <Folder>tools</Folder> | ||
| </Mods> | ||
| <ScannerExts>cs; gui; taml; module;</ScannerExts> | ||
| <ScannerExts>cs; gui; taml; module; tscript;</ScannerExts> |
There was a problem hiding this comment.
<ScannerExts>@TORQUE_SCRIPT_EXTENSION@; gui; taml; module;</ScannerExts>
Azaezel
added a commit
to Azaezel/Torque3D-1
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.