Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fade/Hide OOC characters on the map scan #475

Closed
Solanya opened this issue Dec 8, 2020 · 0 comments · Fixed by #696
Closed

Fade/Hide OOC characters on the map scan #475

Solanya opened this issue Dec 8, 2020 · 0 comments · Fixed by #696
Assignees
@Solanya
Labels
enhancement
Milestone
2.4

Comments

@Solanya
Copy link
Member

Solanya commented Dec 8, 2020

One adjustment to be considered for the map scan would be to fade or hide OOC characters from the map scan by default (likely offering an option not to). This would allow to quickly filter out people who aren't currently roleplaying, making it easier to find actual spots of activity.
@Solanya Solanya added this to the 2.4 milestone May 30, 2022
@Solanya Solanya self-assigned this May 30, 2022
Meorawr added a commit that referenced this issue Feb 19, 2023
@Meorawr
Hide OOC characters on map scan by default
6a29c46 
Closes #475. This adds a new configurable option to hide OOC players
from the map scan results. Per the ticket, this option is enabled
by default.

For compatibility with existing clients on the network we treat all
incoming scan responses that don't supply a roleplay status value
as being in-character.

To additionally differentiate between IC and OOC characters in the
scan results, the pin tooltip will now additionally display an "(OOC)"
suffix for characters. For lone pins, they will also be faded out.
@Meorawr Meorawr mentioned this issue Feb 19, 2023
Merged
Solanya added a commit that referenced this issue Feb 20, 2023
@Meorawr @Solanya
Hide OOC characters on map scan by default (#696)
7c2c6cf 
Closes #475. This adds a new configurable option to hide OOC players
from the map scan results. Per the ticket, this option is enabled
by default.

For compatibility with existing clients on the network we treat all
incoming scan responses that don't supply a roleplay status value
as being in-character.

To additionally differentiate between IC and OOC characters in the
scan results, the pin tooltip will now additionally display an "(OOC)"
suffix for characters. For lone pins, they will also be faded out.

Co-authored-by: Solanya <solanya@totalrp3.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Solanya Solanya

Labels
enhancement
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

Hide OOC characters on map scan by default Total-RP/Total-RP-3
1 participant
@Solanya