Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Field #345

Merged
merged 19 commits into from Sep 4, 2019

Conversation

@Meorawr
Copy link
Member

commented Aug 30, 2019

This field displays an icon in the tooltip for a user indicating their preferred roleplay language. On an upgrade, this will initialize to the addon locale if set or will fall back to the client locale.

Wow_2019-08-30_01-29-05

The icon will only display in tooltips if it differs from the users currently selected locale; so you won't see enUS flags if you're running TRP with the enUS locale selected since the info isn't all that useful in that case.

The setting can be changed from the dashboard as a new dropdown with the RP status/RP XP options.

Wow_2019-08-30_01-38-25

Note: Flags aren't displayed in that dropdown because the Chinese locales artifically scale up the flags, making them look unaligned and horrible.

If the user changes the addon locale, we'll run through all the profiles and if the language set for any profile matches the locale we're changing from, we'll update it automatically. I'd have preferred to prompt for this, but we're already popping up a prompt to do a reload UI in this case so having two back to back prompts feels nasty. This behaviour feels sensible as a default.

We only support the locale codes present in our localization system (which mirror those returned by GetLocale); for accuracy in EU/RU clients we'll transform enUS and ptBR to enGB and ptPT respectively. This pulls in LibRealmInfo to do so on Retail, but will fall back to GetCurrentRealmName() if that data is unavailable.

The field is exposed via LibMSP in the LC field as described in wow-rp-addons/LibMSP#26.

Add roleplay language field
This field displays an icon in the tooltip for a user indicating
their preferred roleplay language. On an upgrade, this will initialize
to the addon locale if set or will fall back to the client locale.

The setting can be changed from the dashboard as a new dropdown
with the RP status/RP XP options.

The icon will only display in tooltips if it differs from the
users currently selected locale; so you won't see enUS flags if
you're running TRP with the enUS locale selected since the info
isn't all that useful in that case.

@Meorawr Meorawr added the enhancement label Aug 30, 2019

Meorawr added 4 commits Aug 30, 2019
@Meorawr

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Just to confirm the flag image licensing stuff: https://github.com/tkrotoff/famfamfam_flags

As stated on http://famfamfam.com/lab/icons/flags/: "These flag icons are available for free use for any purpose with no requirement for attribution."

@Meorawr Meorawr referenced this pull request Aug 30, 2019
@Meorawr Meorawr referenced this pull request Aug 30, 2019
Meorawr added 5 commits Aug 31, 2019
Split dashboard status panel to its own file
Also relocated the MSA-based UIDropdownMenuTemplate to the general
purpose UI widgets.xml file, and refactored the dashboard status
code to be a bit simpler.
Meorawr and others added 7 commits Sep 1, 2019
@Solanya
Solanya approved these changes Sep 4, 2019

@Solanya Solanya merged commit e9058d9 into development Sep 4, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@Meorawr Meorawr deleted the feature/language-field branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.