Feature/runtime exec #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is missing license in all new files |
|
@ricardobna made some changes, could you review them? |
Adding Runtime and Proccess on Java side and Runtime and cpproc on c side, cpproc is responsible to execute the command and Runtime is responsible to make the Streams and make the Proccess to be returned.
Trying this to see if I can get access to the InputStream on java
Also implementing some exceptions to those functions.
This change was made so It's easier to deallocate the char pointers used to pass the command, path and environment arrays to cpproc_forkAndExec
…Impl4D.java removing leftover from bytebuffer support Co-authored-by: flsobral <flsobral@gmail.com>
…eBuffer to byteArray for better readability
ricardobna
force-pushed
the
feature/runtime-exec
branch
from
f1e5b04
to
8eb230b
Compare
flsobral
reviewed
May 19, 2020
flsobral
reviewed
May 19, 2020
flsobral
reviewed
May 19, 2020
flsobral
reviewed
May 19, 2020
flsobral
approved these changes
May 19, 2020
ItaloYeltsin
suggested changes
May 19, 2020
…MakeLists on android
ItaloYeltsin
approved these changes
May 26, 2020
9 tasks
flsobral
added a commit
that referenced
this issue
Jul 16, 2020
* Adding Runtime.exec Adding Runtime and Proccess on Java side and Runtime and cpproc on c side, cpproc is responsible to execute the command and Runtime is responsible to make the Streams and make the Proccess to be returned. * FileInputChannel implementation * Creating FileInputStream and and returning the Proccess with it * Fixing stream to use byte array instead of ByteBuffer on java side * Binding OutputStream and ErrorStream * Set file descriptors to the value returned from cpproc_forkAndExec * OutputStream and ErrorStream * Calling cpproc_forAndExec with correct values * Fixing malloc and strings * Testing with filePath NULL * Runtime.exec working without path. * Updating Runtime interface and adding filePath to Runtime.c * Forgotten chdir * Adding exitValue, waitFor and destroy. * Changing memory allocation to heap on Runtime and fixing some exceptions This change was made so It's easier to deallocate the char pointers used to pass the command, path and environment arrays to cpproc_forkAndExec Co-authored-by: flsobral <flsobral@gmail.com> * Adding exception to reads with error value on return and changing byteBuffer to byteArray for better readability * Adding exception to windows, android and iOS and adding the file to CMakeLists on android Co-authored-by: Allan C <acmlira@gmail.com> Co-authored-by: flsobral <flsobral@gmail.com>
flsobral
added a commit
that referenced
this issue
Jul 24, 2020
* Adding Runtime.exec Adding Runtime and Proccess on Java side and Runtime and cpproc on c side, cpproc is responsible to execute the command and Runtime is responsible to make the Streams and make the Proccess to be returned. * FileInputChannel implementation * Creating FileInputStream and and returning the Proccess with it * Fixing stream to use byte array instead of ByteBuffer on java side * Binding OutputStream and ErrorStream * Set file descriptors to the value returned from cpproc_forkAndExec * OutputStream and ErrorStream * Calling cpproc_forAndExec with correct values * Fixing malloc and strings * Testing with filePath NULL * Runtime.exec working without path. * Updating Runtime interface and adding filePath to Runtime.c * Forgotten chdir * Adding exitValue, waitFor and destroy. * Changing memory allocation to heap on Runtime and fixing some exceptions This change was made so It's easier to deallocate the char pointers used to pass the command, path and environment arrays to cpproc_forkAndExec Co-authored-by: flsobral <flsobral@gmail.com> * Adding exception to reads with error value on return and changing byteBuffer to byteArray for better readability * Adding exception to windows, android and iOS and adding the file to CMakeLists on android Co-authored-by: Allan C <acmlira@gmail.com> Co-authored-by: flsobral <flsobral@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Exec method for Runtime class done.