Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Torizon/Wayland SDL initialization #35

Merged
merged 8 commits into from Jun 2, 2020

Conversation

acmlira
Copy link
Contributor

@acmlira acmlira commented May 25, 2020

Highlights:

  • Fix Torizon/Wayland SDL initialization 馃槅 ;
  • Improves how we handle Pixel Format;
  • Bypass SDL_Surface;
  • Better comments and function descriptions.

@acmlira acmlira requested a review from flsobral May 25, 2020
@ItaloYeltsin
Copy link
Contributor

@ItaloYeltsin ItaloYeltsin commented May 26, 2020

waiting for more changes

Changes:
- SDL_Window is now initialized inside TCSDL_Init;
- Pixel format as arg of initSkia;
- Fix ARM display bounds;
- Linux ARM is now a fullscreen platform;
Copy link
Member

@flsobral flsobral left a comment

(y)

@acmlira acmlira requested a review from ItaloYeltsin Jun 2, 2020
@ItaloYeltsin ItaloYeltsin merged commit 2faaeb0 into develop Jun 2, 2020
@ItaloYeltsin ItaloYeltsin deleted the feature/torizon-wayland-enhancement branch Jun 2, 2020
flsobral pushed a commit that referenced this issue Jul 16, 2020
* Escapes from SDL_CreateSurface

SDL_CreateSurface broken pipe in Torizon Wayland (only?)  fixed with malloc pixels to skia. Performance upgrade in 6DL.

* Better error handling

* Screen adjusted only at the end, viewport used to create the renderer

* Better TCSDL function names 馃槉

* Removes global pitch + pixels

Get this args in `screen`

* SDL destroy method + init int return to bool

* Linux: windows with application title

* Removes  global SDL_Window, fullscreen  selection and better comments

Changes:
- SDL_Window is now initialized inside TCSDL_Init;
- Pixel format as arg of initSkia;
- Fix ARM display bounds;
- Linux ARM is now a fullscreen platform;
flsobral pushed a commit that referenced this issue Jul 24, 2020
* Escapes from SDL_CreateSurface

SDL_CreateSurface broken pipe in Torizon Wayland (only?)  fixed with malloc pixels to skia. Performance upgrade in 6DL.

* Better error handling

* Screen adjusted only at the end, viewport used to create the renderer

* Better TCSDL function names 馃槉

* Removes global pitch + pixels

Get this args in `screen`

* SDL destroy method + init int return to bool

* Linux: windows with application title

* Removes  global SDL_Window, fullscreen  selection and better comments

Changes:
- SDL_Window is now initialized inside TCSDL_Init;
- Pixel format as arg of initSkia;
- Fix ARM display bounds;
- Linux ARM is now a fullscreen platform;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants