fix BORDER_ROUNDED on Container for linux arm devices #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: wrong round rect draw when using setBorderStyle(BORDER_ROUNDED) on Container. Also the draw was made on GPU. devices: linux_arm devices. solution: primitives was changed from to fillRoundRect and drawRoundRect in order to use GPU and the behave is kept on simulator.
ItaloYeltsin
force-pushed
the
bugfix/cotainer-rounded-borders
branch
from
f4f8985 to
c531d78
Compare
ricardobna
approved these changes
Jun 9, 2020
flsobral
pushed a commit
that referenced
this pull request
Jul 16, 2020
problem: wrong round rect draw when using setBorderStyle(BORDER_ROUNDED) on Container. Also the draw was made on CPU. devices: linux arm devices. solution: primitives was changed from drawWindowBorder to fillRoundRect and drawRoundRect in order to use GPU. The old behave is kept on simulator because it works on it.
flsobral
pushed a commit
that referenced
this pull request
Jul 24, 2020
problem: wrong round rect draw when using setBorderStyle(BORDER_ROUNDED) on Container. Also the draw was made on CPU. devices: linux arm devices. solution: primitives was changed from drawWindowBorder to fillRoundRect and drawRoundRect in order to use GPU. The old behave is kept on simulator because it works on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When using Container.setStyle(BORDER_ROUNDED), the rounded border is drawn on java side using CPU and the draw is not right on linux arm resulting in a terrible rounded rectangle draw.
Solution: now BORDER_ROUNDED is drawn using Graphics primitives fillRoundedRect and drawRoundedRect. This allows GPU to take care of this draw fixing the terrible behaviour above. The simulator side keeps the solution above because roundrect does not draw beatufil round rectangles.
Description:
When using Container.setBorderStyle(BORDER_ROUNDED), a rounded rectangle is designed representing such a container. On linux arm devices, the draw is very creepy. In addition the draw is made on the Java side using CPU.
Related Issue:
Motivation and Context:
This was made to get a more beautiful draw when using rounded borders on containers
Benefited Devices:
Tested Devices: