Fix wrong FontMetrics.stringWidth(String s) on devices that use skia #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es that use skia when loading font ending with name ending with .ttf
Font.getFont("Fonts/Roboto-Bold.ttf", false, size) leads FontMetrics.stringWidth(String s) to returns almost double of the size of the font. The reason this is happening is because on the vm side it already adds .ttf the end of the name of the font making the vm look for Fonts/Roboto-Bold.ttf.ttf instead of the originally passed argument. To solve this, I check if name of the font already come with .ttf before concatenating .ttf to the of the name.
ItaloYeltsin
force-pushed
the
bugfix/font-stringwidth
branch
from
20a8249
to
fa9f486
Compare
acmlira
approved these changes
Jun 12, 2020
flsobral
pushed a commit
that referenced
this pull request
Jul 16, 2020
…es that use skia when loading font ending with name ending with .ttf (#50) Font.getFont("Fonts/Roboto-Bold.ttf", false, size) leads FontMetrics.stringWidth(String s) to returns almost double of the size of the font. The reason this is happening is because on the vm side it already adds .ttf the end of the name of the font making the vm look for Fonts/Roboto-Bold.ttf.ttf instead of the originally passed argument. To solve this, I check if name of the font already come with .ttf before concatenating .ttf to the of the name.
flsobral
pushed a commit
that referenced
this pull request
Jul 24, 2020
…es that use skia when loading font ending with name ending with .ttf (#50) Font.getFont("Fonts/Roboto-Bold.ttf", false, size) leads FontMetrics.stringWidth(String s) to returns almost double of the size of the font. The reason this is happening is because on the vm side it already adds .ttf the end of the name of the font making the vm look for Fonts/Roboto-Bold.ttf.ttf instead of the originally passed argument. To solve this, I check if name of the font already come with .ttf before concatenating .ttf to the of the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Font.getFont("Fonts/Roboto-Bold.ttf", false, size) leads FontMetrics.stringWidth(String s) to returns almost double of the size of the font. The reason this is happening is because on the vm side it already adds .ttf the end of the name of the font making the vm look for Fonts/Roboto-Bold.ttf.ttf instead of the originally passed argument. To solve this, I check if name of the font already comes with .ttf before concatenating .ttf to the of the name.
Motivation and Context:
Wrong Label width because when using
Font.getFont("Fonts/Roboto-Bold.ttf", false, size)instead ofFont.getFont("Fonts/Roboto-Bold", false, size)without.ttf.Benefited Devices:
How Has This Been Tested?
Tested Devices: