Fixes wrong scroll behaviour on horizontal and improves scroll performance #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance When using horizontal scroll the flick effect was pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X).
flsobral
approved these changes
Jul 1, 2020
flsobral
pushed a commit
that referenced
this pull request
Jul 16, 2020
…ance (#54) When using horizontal scroll the flick effect was pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X).
flsobral
pushed a commit
that referenced
this pull request
Jul 24, 2020
…ance (#54) When using horizontal scroll the flick effect was pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X).
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flick effect introduced on TotalCross 5.0.0 causes, when using horizontal scroll, the wrong behaviour of pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X). In addition, this made an noticeable improvement on the performance of the ScrollContainer component. Besides we have a less smooth scroll, at least now we have an 100% functional scroll, not beautiful, but functional!
Motivation and Context:
Fixes wrong behaviour caaused by flick and improves performance of scroll.
Benefited Devices:
How Has This Been Tested?
Two tests were performed
i) I've added an horizontal scroll with a bunch of icons on it. When flicking on the old version (5.1.4 and 6.0.4), the scroll was pulling baack to initial position.
ii) I've put a number of Buttons (100) and tested the performance.
Both problems were fixed on this bugfix.
Tested Devices:
Screenshots