Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong scroll behaviour on horizontal and improves scroll performance #54

Merged
merged 1 commit into from Jul 1, 2020

Conversation

ItaloYeltsin
Copy link
Contributor

@ItaloYeltsin ItaloYeltsin commented Jun 24, 2020

The flick effect introduced on TotalCross 5.0.0 causes, when using horizontal scroll, the wrong behaviour of pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X). In addition, this made an noticeable improvement on the performance of the ScrollContainer component. Besides we have a less smooth scroll, at least now we have an 100% functional scroll, not beautiful, but functional!

Motivation and Context:

Fixes wrong behaviour caaused by flick and improves performance of scroll.

Benefited Devices:

  • Device: All
  • OS: All

How Has This Been Tested?

Two tests were performed
i) I've added an horizontal scroll with a bunch of icons on it. When flicking on the old version (5.1.4 and 6.0.4), the scroll was pulling baack to initial position.
ii) I've put a number of Buttons (100) and tested the performance.

Both problems were fixed on this bugfix.

Tested Devices:

  • Device: Motog G4
  • OS: Android 6.0

Screenshots

image

…ance

When using horizontal scroll the flick effect was pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X).
@ItaloYeltsin ItaloYeltsin requested a review from flsobral Jun 24, 2020
@flsobral flsobral merged commit 6f01d7c into develop Jul 1, 2020
@flsobral flsobral deleted the bugfix/wrong-flick-behaviour branch Jul 1, 2020
flsobral pushed a commit that referenced this issue Jul 16, 2020
…ance (#54)

When using horizontal scroll the flick effect was pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X).
flsobral pushed a commit that referenced this issue Jul 24, 2020
…ance (#54)

When using horizontal scroll the flick effect was pulling the content back to the initial position. In order to fix it. I reverted the class Flick.java to the previous version (4.X.X).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants