Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Eager services #1406

Merged
merged 7 commits into from Feb 9, 2021
Merged

[Feature] Eager services #1406

merged 7 commits into from Feb 9, 2021

Conversation

mproch
Copy link
Collaborator

@mproch mproch commented Feb 3, 2021

EagerService + ServiceInvoker can be used to create service objects using fixed parameters.
Lifecycle is handled on the level of "main" EagerService.
TODO: cleanup, refactor of ServiceQuery

@mproch mproch force-pushed the eager_service branch 6 times, most recently from e3cf511 to bcb70d2 Compare February 3, 2021 11:46
@mproch mproch changed the title EagerServices [Feature] Eager services - WIP Feb 3, 2021
@mproch mproch changed the title [Feature] Eager services - WIP [Feature] Eager services Feb 6, 2021
@mproch mproch marked this pull request as ready for review February 6, 2021 08:26
@arkadius
Copy link
Member

arkadius commented Feb 8, 2021

  1. Can we deprecate ServiceReturningType (with recommended migration to EagerService + ReturningType) in this change?
  2. Also maybe it is also good time to deprecate WithExplicitMethodToInvoke.returnType and ServiceWithExplicitMethod? Because IMO better way now is to implement EagerService with WithExplicitMethodToInvoke returning ServiceInvoker with ReturningType - this approach has no limitation that user can't use eager parameters during compuation of returnType

@mproch
Copy link
Collaborator Author

mproch commented Feb 8, 2021

  1. Can we deprecate ServiceReturningType (with recommended migration to EagerService + ReturningType) in this change?
    True, I added deprecation
  2. Also maybe it is also good time to deprecate WithExplicitMethodToInvoke.returnType and ServiceWithExplicitMethod? Because IMO better way now is to implement EagerService with WithExplicitMethodToInvoke returning ServiceInvoker with ReturningType - this approach has no limitation that user can't use eager parameters during compuation of returnType

Here I would like to refactor it a bit in next PR. I believe ServiceWithExplicitMethod would still be valuable, but it should be a helper function which implements stuff with GenericNodeTransformation

@mproch mproch merged commit 1922e1b into TouK:staging Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants