Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: scenario node category verification on validation #3370

Merged
merged 2 commits into from Aug 9, 2022

Conversation

lciolecki
Copy link
Contributor

No description provided.

@lciolecki lciolecki force-pushed the feature/scenario-node-type-validation branch 2 times, most recently from 93125f4 to e3818fe Compare August 4, 2022 12:07
@lciolecki lciolecki requested a review from mproch August 4, 2022 12:08
@lciolecki lciolecki marked this pull request as ready for review August 4, 2022 12:08
@github-actions github-actions bot added the docs label Aug 4, 2022
@lciolecki lciolecki changed the title Feature: scenario node strict validation Feature: scenario node category veryfication Aug 4, 2022
@lciolecki lciolecki changed the title Feature: scenario node category veryfication Feature: scenario node category verification Aug 4, 2022
@lciolecki lciolecki changed the title Feature: scenario node category verification Feature: scenario node category verification on validation Aug 4, 2022
@lciolecki lciolecki force-pushed the feature/scenario-node-type-validation branch 3 times, most recently from b7ef3f4 to 68ecfe8 Compare August 4, 2022 12:24
Copy link
Collaborator

@mproch mproch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added some minor comments

@lciolecki lciolecki force-pushed the feature/scenario-node-type-validation branch 3 times, most recently from 5329612 to 048b3b3 Compare August 9, 2022 07:01
Copy link
Collaborator

@mproch mproch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, thanks. I think we should also add entry in MigrationGuide... As we know, there are some users who export/import components from different categories :)

@lciolecki lciolecki force-pushed the feature/scenario-node-type-validation branch from 048b3b3 to bc4dc94 Compare August 9, 2022 07:27
@lciolecki lciolecki force-pushed the feature/scenario-node-type-validation branch from bc4dc94 to 70ddd13 Compare August 9, 2022 07:55
@lciolecki lciolecki merged commit d02b9b9 into staging Aug 9, 2022
@lciolecki lciolecki deleted the feature/scenario-node-type-validation branch May 31, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants